Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement on github CI actions to test build process #222

Open
berinhard opened this issue Jan 1, 2023 · 0 comments · May be fixed by #225
Open

Improvement on github CI actions to test build process #222

berinhard opened this issue Jan 1, 2023 · 0 comments · May be fixed by #225

Comments

@berinhard
Copy link
Owner

berinhard commented Jan 1, 2023

The version 0.7.2 was broken because the build package didn't have the required templates and static files in order for the serve command to work. The issue was caused because I had to rename the http app to http_local (more about this in #220).

The problem was fixed in 0.7.3 by updating the the manifest and setup files (more in 14be8d5).

To avoid this to happen again, we could add a linux script that would:

  • run python3 setup.py sdist bdist_wheel;
  • check if all the assets/template files are present in the final build;

If not, the build should fail and, thus, the PR cannot be merged.

pedroqueiroga added a commit to pedroqueiroga/pyp5js that referenced this issue Apr 1, 2023
pedroqueiroga added a commit to pedroqueiroga/pyp5js that referenced this issue Apr 1, 2023
pedroqueiroga added a commit to pedroqueiroga/pyp5js that referenced this issue Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant