New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get marathon package from PyPi in stead of github #1

Merged

bergerx merged 1 commit into bergerx:master from rvalkenaers:master

Jul 31, 2016

rvalkenaers commented Jul 19, 2016 •

edited

Loading

I'm having issue with the current docker image (https://hub.docker.com/r/bergerx/prom-marathon-app-exporter/) which gives me a 500 internal server error. It seems to crash on this line https://github.com/bergerx/prom_marathon_app_exporter/blob/master/collector.py#L54

Using the marathon package from PyPi seems to solve it for me.

The package on PyPi comes from this repo https://github.com/thefactory/marathon-python which is updated more recently.


          Get marathon package from PyPi in stead of github

eaee523

bergerx merged commit 1050bd7 into bergerx:master

Owner

bergerx commented Jul 31, 2016

@rvalkenaers thanks for the pull request, when I was implementing this for the first time I also created thefactory/marathon-python#89 for the upstream project. Apparently my changes were added at 0.8.0 version (https://github.com/thefactory/marathon-python/blob/master/CHANGELOG.md#080-2016-04-18) and i didn't follow up the the release, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet