Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(payload): dropped optimistic payload building #2520

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

abi87
Copy link
Collaborator

@abi87 abi87 commented Feb 18, 2025

just checking what the code looks like without it

@abi87 abi87 added the DO NOT MERGE just don't merge it (just yet) label Feb 18, 2025
@abi87 abi87 self-assigned this Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 32.43%. Comparing base (5e3edfa) to head (2bef2c7).

Files with missing lines Patch % Lines
beacon/blockchain/service.go 0.00% 12 Missing ⚠️
beacon/blockchain/process_proposal.go 0.00% 4 Missing ⚠️
payload/builder/payload.go 0.00% 4 Missing ⚠️
beacon/validator/block_builder.go 0.00% 1 Missing ⚠️
beacon/validator/config.go 0.00% 1 Missing ⚠️
testing/e2e/config/defaults.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2520      +/-   ##
==========================================
+ Coverage   32.30%   32.43%   +0.13%     
==========================================
  Files         350      349       -1     
  Lines       15674    15361     -313     
  Branches       20       20              
==========================================
- Hits         5064     4983      -81     
+ Misses      10247    10021     -226     
+ Partials      363      357       -6     
Files with missing lines Coverage Δ
beacon/blockchain/metrics.go 0.00% <ø> (ø)
beacon/blockchain/payload.go 0.00% <ø> (ø)
beacon/validator/metrics.go 0.00% <ø> (ø)
node-core/components/chain_service.go 0.00% <ø> (ø)
node-core/components/payload_builder.go 0.00% <ø> (ø)
payload/builder/builder.go 0.00% <ø> (-100.00%) ⬇️
testing/e2e/config/config.go 0.00% <ø> (ø)
beacon/validator/block_builder.go 0.00% <0.00%> (ø)
beacon/validator/config.go 0.00% <0.00%> (ø)
testing/e2e/config/defaults.go 0.00% <0.00%> (ø)
... and 3 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE just don't merge it (just yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant