Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ add configurable DNS addresses #30 #103

Merged
merged 1 commit into from
May 19, 2024
Merged

feat: ✨ add configurable DNS addresses #30 #103

merged 1 commit into from
May 19, 2024

Conversation

pizokh
Copy link

@pizokh pizokh commented May 18, 2024

  • Added default DNS addresses and a command-line option (--dns-addr) to customize them.

markpash
markpash reviewed May 18, 2024
View reviewed changes
Copy link
Member

@markpash markpash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! I've left some comments for some changes.

app/app.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
warp/account.go Outdated Show resolved Hide resolved
@pizokh
Copy link
Author

pizokh commented May 19, 2024

Thank you for the feedback, @markpash! I have made the requested changes:

  • Changed DnsAddr from []string to netip.Addr in WarpOptions.
  • Updated the command-line option to be a single string using fs.StringLong with 1.1.1.1 as the default.
  • Removed the defaultDnsAddr list and associated logic.
  • Adjusted the DNS setup to be handled directly in runWarp(), runWarpInWarp(), and runWarpWithPsiphon() functions.
  • Updated the createConf and LoadOrCreateIdentity functions to reflect these changes.

Please review the updated implementation. Let me know if any further adjustments are needed.

@pizokh pizokh force-pushed the feature/dnsAddress branch 3 times, most recently from 8192140 to 878b6cc Compare May 19, 2024 10:26
@pizokh pizokh requested a review from markpash May 19, 2024 10:28
markpash
markpash requested changes May 19, 2024
View reviewed changes
wiresocks/config.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@pizokh pizokh force-pushed the feature/dnsAddress branch from 878b6cc to 5958a8e Compare May 19, 2024 12:09
@pizokh
feat: ✨ add DNS configuration support bepass-org#30
f67349c 
- Add default DNS address (1.1.1.1), and a command-line option (--dns) to customize it.
@pizokh pizokh force-pushed the feature/dnsAddress branch from 5958a8e to f67349c Compare May 19, 2024 12:10
@pizokh pizokh requested a review from markpash May 19, 2024 12:13
@markpash markpash merged commit 6179fff into bepass-org:master May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpash markpash markpash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pizokh @markpash