Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the use of pkg_resources with importlib.metadata #2840

Closed
webknjaz opened this issue Aug 3, 2022 · 1 comment
Closed

Replace the use of pkg_resources with importlib.metadata #2840

webknjaz opened this issue Aug 3, 2022 · 1 comment
Assignees
@benoitc
Labels
Deploy Feature/Config
Milestone
22.0

Comments

@webknjaz
Copy link

webknjaz commented Aug 3, 2022

Hello, using pkg_resources in gunicorn.util causes a deprecation warning to be issued down the stack (it's coming from sre_constants imported py the vendored pyparsing).

The use of pkg_resources has been heavily discouraged over the past years and nowadays the recommended alternative exists. It's called importlib.metadata and it's present in the modern CPython stdlib. For older interpreter versions, there's also an importlib_metadata backport packaged and published separately to PyPI. It can be used as a fallback.

https://importlib-metadata.readthedocs.io/en/latest/api.html#importlib_metadata.entry_points
webknjaz added a commit to aio-libs/aiohttp that referenced this issue Aug 3, 2022
@webknjaz
Ignore third-party deprecation warnings @ py311
bddb77d 
Refs:
* benoitc/gunicorn#2840
* certifi/python-certifi#199
webknjaz added a commit to aio-libs/aiohttp that referenced this issue Aug 3, 2022
@webknjaz
Ignore third-party deprecation warnings @ py311
4720070 
Refs:
* benoitc/gunicorn#2840
* certifi/python-certifi#199

(cherry picked from commit bddb77d)
webknjaz added a commit to aio-libs/aiohttp that referenced this issue Aug 3, 2022
@webknjaz
Ignore third-party deprecation warnings @ py311
5a8721f 
Refs:
* benoitc/gunicorn#2840
* certifi/python-certifi#199

(cherry picked from commit bddb77d)
@mattwang44 mattwang44 mentioned this issue Apr 28, 2023
Closed
@benoitc benoitc added this to the 21.0 release milestone May 7, 2023
@benoitc benoitc self-assigned this May 7, 2023
@tilgovi tilgovi modified the milestones: 21.0, 22.0 Dec 28, 2023
@tilgovi
Copy link
Collaborator

tilgovi commented Dec 29, 2023

I believe this was closed by #2963.

@tilgovi tilgovi closed this as completed Dec 29, 2023
@EdwinWiseOne EdwinWiseOne mentioned this issue Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitc benoitc

Labels
Deploy Feature/Config
Projects
None yet
Milestone
22.0
Development

No branches or pull requests
3 participants
@benoitc @tilgovi @webknjaz