Implement positivty limiter with numbers for conservative variables #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennibolm
commented
Jun 19, 2023
Comment on lines
+243
to
+245
| struct IndicatorIDP{RealT <: Real, Cache} <: AbstractIndicator | ||
| positivity::Bool | ||
| variables_cons::LimitingVariablesCons # Positivity of conservative variables | ||
| variables_cons::Vector{Int} # Impose positivity for conservative variables |
There was a problem hiding this comment.
I am not sure if a tuple or an array is more useful. The length can vary depending on the example, which is why I now use an array. Is there still the possibility to use a tuple with undefined length?
The non-linear variables (in latter PRs) are still passed as functions in a tuple. But maybe the same type (tuple/array) should be used here (?).
1 task
bennibolm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the call of the IDP positivity limiter. One uses an array of numbers to call the positivity limiter for conservative variables. Before, we used a tuple of functions. This change is useful when adding state limiting of conservative variables in the future.
Example (limiting density of Euler equations): Use
variables_cons=[1]instead ofvariables_cons=(Trixi.density,)