Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singletap not fired on sensitive Android devices #112

Closed
danielhalldin opened this issue Oct 12, 2016 · 3 comments
Closed

Singletap not fired on sensitive Android devices #112

danielhalldin opened this issue Oct 12, 2016 · 3 comments
Assignees
Labels
enhancement The issue contains enhancements or improvements that will be added to future releases.

Comments

@danielhalldin
Copy link

danielhalldin commented Oct 12, 2016

A suggested solution is to add the swipe threshold, like this:
Line 406:
if (!$this.data('doubletapped') && !$this.data('tapheld') && (Math.abs(start_pos.x - end_pos_x) < settings.swipe_v_threshold) && (Math.abs(start_pos.y - end_pos_y) < settings.swipe_h_threshold)) {

@benmajor benmajor added the enhancement The issue contains enhancements or improvements that will be added to future releases. label Oct 12, 2016
@benmajor benmajor self-assigned this Oct 12, 2016
@benmajor
Copy link
Owner

Thank you for the heads-up. I'll add this to implement for v1.1.

@danielhalldin
Copy link
Author

👍

benmajor added a commit that referenced this issue Nov 16, 2016
- Added slop factor for `singletap` (issue #104 and #112)
- Fixed an issue where `offset()` was being called on `null`; now defaults to 0.
benmajor added a commit that referenced this issue Nov 16, 2016
- Added slop factor for `singletap` (issue #104 and #112)
- Fixed an issue where `offset()` was being called on `null`; now defaults to 0.
@benmajor
Copy link
Owner

This has now been fixed in the latest commit: 7271901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue contains enhancements or improvements that will be added to future releases.
Projects
None yet
Development

No branches or pull requests

2 participants