Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing import declarations #209

Merged
merged 1 commit into from
Aug 10, 2015
Merged

Conversation

fkling
Copy link
Contributor

@fkling fkling commented Aug 10, 2015

ESTree (esprima and Babel) puts the identifier name in the "local" property, not the "id" property.

See http://felix-kling.de/esprima_ast_explorer/#/3lOF4MIKlj and facebook/jscodeshift/issues/33

Do you want me to provide tests?

ESTree (epsrima and Babel) puts the identifier name in the "local" property,
not the "id" property.
benjamn added a commit that referenced this pull request Aug 10, 2015
Fix printing ImportNamespaceSpecifier and ImportDefaultSpecifier.
@benjamn benjamn merged commit 351fd38 into benjamn:master Aug 10, 2015
@benjamn
Copy link
Owner

benjamn commented Aug 10, 2015

@fkling
Copy link
Contributor Author

fkling commented Aug 10, 2015

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants