Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that long sections are truncated #180

Merged
merged 4 commits into from
Oct 27, 2024

Conversation

isidroas
Copy link
Contributor

  • test that long sections are truncated
  • generated .txt executing unittest.sh
  • expected result

Should we revert the commit 9f0a1d2 to prevent the CI from failing?

It seems related with a more general issue ( #145 )

@benhoyt
Copy link
Owner

benhoyt commented Oct 27, 2024

Yeah, I've reverted 9f0a1d2 as I think it's actually the correct behaviour, because len(section) > len(INI_MAX_LINE) for these tests. I'd like to improve the tests so that tests aren't so dependent on each other, but I'll do that later. Merging this now.

@benhoyt benhoyt merged commit f93ad93 into benhoyt:master Oct 27, 2024
2 checks passed
@benhoyt
Copy link
Owner

benhoyt commented Oct 27, 2024

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants