Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to JFileChooser on Mac with VAqua #88

Merged
merged 17 commits into from
Aug 15, 2020
Merged

Switch to JFileChooser on Mac with VAqua #88

merged 17 commits into from
Aug 15, 2020

Commits on Mar 8, 2020

  1. Fix uninitalized debugger in JavaEditor. 

    Looks like constructor in Editor called from from JavaEditor is calling an overloaded method back in JavaEditor that expects debugger to have been initialized which is not possible since the parent constructor has not returned. This switches to loading debugger on demand (upon calling getDebugger) which allows for the Editor to use overloaded methods that expect debugger to be initialized.
    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    507e7fa View commit details
    Browse the repository at this point in the history

  2. Require JavaEditor subclass use getDebugger().

    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    86b92bc View commit details
    Browse the repository at this point in the history

  3. Made JavaEditor debugger private.

    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    18653e2 View commit details
    Browse the repository at this point in the history

  4. Made preprocService and debugger visibility consistent in JavaEditor.

    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    926c458 View commit details
    Browse the repository at this point in the history

  5. Fixed enable debugger on clicking debug button.

    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    d126c70 View commit details
    Browse the repository at this point in the history

  6. Minor cleanup related to #74.

    @sampottinger
    sampottinger committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    3979d9a View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2020

  1. Switch to JFileChooser on Mac per #77. 

    Due to the regression in FileDialog causing command c / command v to no longer work within FileDialog on Mac, having OS X use JFileChooser for the editor. This is keeping with the precedent set in processing/processing#1035.
    @sampottinger
    sampottinger committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    865281a View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Switch to VAqua on Mac for dark mode and non-terrible jfilechooser.

    @sampottinger
    sampottinger committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    a4f112c View commit details
    Browse the repository at this point in the history

  2. Added vaqua jar.

    @sampottinger
    sampottinger committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    872add5 View commit details
    Browse the repository at this point in the history

  3. Build vaqua without debugging output.

    @sampottinger
    sampottinger committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    c12c773 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. Added OS X version guard on vaqua. 

    Responded to @clankill3r's feedback, adding a OS X version gaurd before vaqua is enabled.
    @sampottinger
    sampottinger committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    c95e276 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2020

  1. Accept changes on msater for JavaEditor and Debugger.

    @sampottinger
    sampottinger committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    afe01e2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into on_demand_debugger

    @sampottinger
    sampottinger committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    f86f3fb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'on_demand_debugger' into fix_mac_os_save

    @sampottinger
    sampottinger committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    2799fb3 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Changed minimum mac osx version to 10.10. 

    Per @benfry's feedback on #88, moved to 10.10 minimum mac os x
version enforced in Info.plist.
    @sampottinger
    sampottinger committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    eb6a9f7 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Move vaqua to download on demand instead of staying binary in repo.

    @sampottinger
    sampottinger committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    22716f9 View commit details
    Browse the repository at this point in the history

  2. Updated preferences for vaqua per #88.

    @sampottinger
    sampottinger committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    942fa81 View commit details
    Browse the repository at this point in the history