Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Friendly error messages #747

Closed
wants to merge 21 commits into from
Closed

Friendly error messages #747

wants to merge 21 commits into from

Conversation

sampottinger
Copy link
Collaborator

See #741

WillRabalais04 and others added 20 commits March 24, 2023 01:47
@WillRabalais04
Bugfix for Issue #606
9489ad8 
Updates the getStringValue method of the VariableNode class so that it correctly handles multidimensional arrays. The default formatting of multidimensional arrays is to have the size of the first array written in the last set of brackets eg.int[][5]. This changes it so that the returned value has the size of the first array written in the first set of brackets eg.int[5][]. This can parse multidimensional arrays of any size.
@sampottinger
Merge pull request #692 from WillRabalais04/bugfixes
5ec4cdc 
Bugfix for Issue #606
@sampottinger
Refactor to regex and tests.
2fdd3e5 
Closes Debugger lists immediate array dimension last #606.
@sampottinger
Add test to describe null on #713.
cd313c6
@sampottinger
Add failsafe for #713.
5c3fa69
@sampottinger
Add test for failsafe.
674cfe0
@sampottinger
Clarify unneeded section.
0987f67
@sampottinger
Closes #714.
490fc2b 
Depending on how the Problem is made, the error may be given relative to
start of line or start of tab. Flag indicates to users of Problems which
one they are working with.
@sampottinger
Reverse accidential change related to #715.
761db14
@sampottinger
Style fixes related to #715.
e69ad56
@sampottinger
Reverse accidential change for #715.
4039cb7
@sampottinger
Add docstring to Problem.
a0cbb64
@sampottinger
Start refactor of #715 to specific optionals.
9fcf752
@sampottinger
Working again with optionals split.
3ba415c
@sampottinger
Merge pull request #716 from processing/refactor-715-optional
a712ff0 
Start refactor of #715 to specific optionals.
@sampottinger
Added asserts for PdeAdapter.
ecc1dc0
@sampottinger
Merge branch 'differentiate-offset' of github.com:processing/processi…
beb27a1 
…ng4 into differentiate-offset
@sampottinger
Closes #720.
aeb7242 
Fix an issue where tweaks mode wont run if there are semi-transparent
colors in the tab because of a regex issue.
@sampottinger
Merge branch 'differentiate-offset' into sam-preview
1d200f6
@sampottinger
Merge remote-tracking branch 'origin/fix-606-willrabalais' into sam-p…
c7aea0e 
…review
@sampottinger
Copy link
Collaborator Author

sampottinger commented Jul 13, 2023 •
edited
Loading

Hey @WillRabalais04 thanks for starting this and flagging that issue for me on properties. I think you weren't seeing things reflected because #714 is still open. I was hoping to wait for Ben but this will block your work so I'll close #714 and #720 now. Want to make sure it doesn't derail GSoC.

@sampottinger
Copy link
Collaborator Author

@WillRabalais04 - I'll close my PR and open from your fork.

This was referenced Jul 13, 2023
Closed
Closed
@sampottinger sampottinger mentioned this pull request Aug 15, 2023
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampottinger @WillRabalais04