Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast forward JSSC #577

Merged
merged 4 commits into from
Oct 25, 2022
Merged

Fast forward JSSC #577

merged 4 commits into from
Oct 25, 2022

Conversation

sampottinger
Copy link
Collaborator

Fixes #525.

@sampottinger sampottinger marked this pull request as draft October 18, 2022 16:02
@sampottinger
Copy link
Collaborator Author

sampottinger commented Oct 18, 2022 •
edited
Loading

Tested on Intel Mac. Need to test on Linux, Windows, and Mac M1. Luckily java-native upstream uses a fat jar now so distribution is easier but I think we may still need https://github.com/sampottinger/jssc due to the properties and path stuff.

@sampottinger sampottinger mentioned this pull request Oct 18, 2022
Closed
@sampottinger sampottinger marked this pull request as ready for review October 23, 2022 16:21
@sampottinger
Copy link
Collaborator Author

Still don’t have access to an M1 but working on Intel Mac, Windows, and Linux!

@hkiel
Copy link
Contributor

hkiel commented Oct 23, 2022

I have an M1. What exactly is to check? Can you provide a Processing binary distribution for the test?

@sampottinger
Copy link
Collaborator Author

sampottinger commented Oct 23, 2022 via email •
edited
Loading

@sampottinger
Copy link
Collaborator Author

Got my hands on an m1 and there is a path issue there. Working through it now.

@sampottinger sampottinger marked this pull request as draft October 25, 2022 01:59
@sampottinger
Copy link
Collaborator Author

Good news! sampottinger/jssc#9 appears to have fixed it on M1. The only bummper is we are getting SLF4J logging noise :(

Will address that after testing this on linux and windows. Good to go on Mac (M1 and Intel)

@sampottinger
Copy link
Collaborator Author

Linux and Windows look good. Just addressing the SLF4J situation in JSSC.

@sampottinger sampottinger marked this pull request as ready for review October 25, 2022 04:20
@sampottinger
Copy link
Collaborator Author

Sorry about that @benfry. Now working on both macs (intel, M1), windows, and linux.

@benfry benfry merged commit cf4e9b2 into main Oct 25, 2022
@benfry benfry deleted the jssc_fast_forward branch October 25, 2022 10:26
@benfry
Copy link
Owner

benfry commented Oct 25, 2022

Thanks! Now merged for 4.0.2.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benfry benfry Awaiting requested review from benfry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to update to the latest JSSC to work on Apple M1
3 participants
@sampottinger @hkiel @benfry