Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #477 by always returning true if the file was opened #479

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Fixes #477 by always returning true if the file was opened #479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8dc99e
returns whether a file was opened
guilhermesilveira Apr 26, 2022
7c0bbf7
safely returning null only when there is an exception
guilhermesilveira Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/processing/app/Base.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1625,13 +1625,13 @@ public Editor handleOpen(String path) {
nextMode = mode;
}
*/
handleOpenInternal(pdeFile.getAbsolutePath(), false);
return handleOpenInternal(pdeFile.getAbsolutePath(), false);

} catch (IOException e) {
Messages.showWarning("sketch.properties",
"Error while reading sketch.properties from\n" + parentFolder, e);
return null;
}
return null;
}


Expand Down