Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Authentification #357

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

Eskaan
Copy link

@Eskaan Eskaan commented Jan 21, 2022

The feature

Added authentication for proxies and changed settings because you don't need multiple proxies; just one.

What it does

Short: Two things. First, it changes the way proxies are set up so that you no longer have 6 settings for your proxy configuration but 3 (+2 for authentication). You can now set your proxy type and just go on whit host and password. Whit authentication there would have been to many setting entries in my eyes.
Secondly (the main purpose) it adds a way to add the proxy authentication in the settings using the

Why do I want that feature?

I need this feature in the program because my Teacher wants to use it in our school and I don't want to manually search and install every library I want. I will also create a pr for a hopefully portable version of the app by moving the settings into the app or (more likely) creating a file inside of the app containing the path to the settings file (needed because %AppData% resets every time rebooting a school PC). Please tell me if you have a solution in mind so I can build it to your wishes.

Sidenotes

  • I really like the project and will maybe stay as an occasional contributor. It looks well maintained to me. You did an Awesome job here. 👍
  • Maybe there is another way of saving the proxy password than in plain text but it's ok for me.
  • If you don't like the changes I made to the settings tell me, the version whit only the authentication is one push away.
  • I thought of putting handleProxy into the init method but I thought I better leave it. If you want it its done in seconds.

Draft

The proxy authentication still needs testing, I only found a public http proxy whit out authentication to test it. That is why its still a draft; I need someone to test it please (I can first test it by next Thursday).

  • Testing the authentication

@Eskaan Eskaan mentioned this pull request Jan 21, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant