add extra Preferences.save() after chaning theme (fix for #565)

benfry · Nov 25, 2022 · a39f4d7 · a39f4d7
1 parent 926f1d1
commit a39f4d7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/src/processing/app/tools/ThemeSelector.java b/app/src/processing/app/tools/ThemeSelector.java
@@ -340,6 +340,9 @@ private void setCurrentIndex(int index) {
     // preference so that subsequent Processing updates load new theme changes.
     //Util.saveFile(currentSet.get(index), sketchbookFile);
     Preferences.set("theme", currentSet.getPath(index));
+    // On some machines, the theme wasn't getting saved; try an explicit save
+    // https://github.com/processing/processing4/issues/565
+    Preferences.save();
     reloadTheme();
   }
 

diff --git a/todo.txt b/todo.txt
@@ -1,13 +1,14 @@
 1288 (4.1?)
 X bump Java version to 17.0.5
+X theme is not being kept after Processing restart on Windows
+X   unable to reproduce so just hoping this works
+X   https://github.com/processing/processing4/issues/565
 
 
 _ "Show Sketch Folder" for libraries needs to treat the sketch as Untitled
 _   and with that, switch to another directory
 _   https://github.com/processing/processing4/issues/548
 
-_ theme is not being kept after Processing restart on Windows?
-_   https://github.com/processing/processing4/issues/565
 
 _ expanded language codes to support traditional Chinese translation
 _   https://github.com/processing/processing4/issues/600