Skip to content

Commit

Permalink
notes about #592 and pull #597
Browse files Browse the repository at this point in the history
  • Loading branch information
benfry committed Nov 24, 2022
1 parent 52995b3 commit 85a93b0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
6 changes: 3 additions & 3 deletions core/src/processing/core/PShape.java
Original file line number Diff line number Diff line change
Expand Up @@ -1985,10 +1985,10 @@ static protected PImage parseBase64Image(String imagePath) {
String extension = parts[0].substring(11);
String encodedData = parts[1];

// Fix for https://github.com/processing/processing4/issues/592
// If a SVG image has an error, the base 64 will fail, but the browser will work.
// So we are sanitizing the values before reading it.
// If you have any questions, please, read this
// reference: https://www.prostdev.com/post/understanding-the-illegal-base64-character-error-java-groovy-and-mule-4-dw-2-0
// So we are sanitizing the values before reading it:
// https://www.prostdev.com/post/understanding-the-illegal-base64-character-error-java-groovy-and-mule-4-dw-2-0
Base64.Decoder decoder;
if (encodedData.contains("+") || encodedData.contains("/")) {
decoder = Base64.getDecoder();
Expand Down
8 changes: 3 additions & 5 deletions core/todo.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,16 @@ X maybe https://github.com/processing/processing4/issues/487
contribs
X P3D & P2D window not showing on MacOS Ventura (thx @jaegonlee)
X https://github.com/processing/processing4/issues/544
X Loading SVG file gives Illegal base64 character 20 encoding error (worked in v3.5.4)
X https://github.com/processing/processing4/issues/592
X https://github.com/processing/processing4/pull/599

data
X use choice() instead of random() for list classes
X remove random(PApplet) since unlikely to be used/seems overkill
X add choice() as a PApplet method for int values of random()


contrib
_ Loading SVG file gives Illegal base64 character 20 encoding error (worked in v3.5.4)
_ https://github.com/processing/processing4/issues/592
_ https://github.com/processing/processing4/issues/592

_ freeze on resize with Windows (even the default renderer)
_ https://github.com/processing/processing4/issues/507

Expand Down

0 comments on commit 85a93b0

Please sign in to comment.