Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setup_requires #674

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Remove setup_requires #674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baa1c40
Remove setup_requires
benfred Jun 30, 2023
a19df30
Merge branch 'main' into no_setup_requires
benfred Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,8 @@
import io
import os.path

from packaging.version import Version
from setuptools import find_packages
from skbuild import setup
from skbuild.cmaker import get_cmake_version
from skbuild.exceptions import SKBuildError

# Add CMake as a build requirement if cmake is not installed or is too low a version
setup_requires = []
try:
if Version(get_cmake_version()) < Version("3.17"):
setup_requires.append("cmake>=3.17")
except SKBuildError:
setup_requires.append("cmake>=3.17")


def read(file_name):
Expand Down Expand Up @@ -56,6 +45,5 @@ def exclude_non_implicit_cmake_files(cmake_manifest):
),
packages=find_packages(),
install_requires=["numpy", "scipy>=0.16", "tqdm>=4.27"],
setup_requires=setup_requires,
cmake_process_manifest_hook=exclude_non_implicit_cmake_files,
)