Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript default export with ESM (bug #471) #475

Merged
merged 4 commits into from
Mar 31, 2024

Conversation

eXon
Copy link
Collaborator

@eXon eXon commented Mar 31, 2024

It seems like TypeScript is confused when publishing both ESM and CommonJS. To make it clear it is ESM, I must rename the d.ts files into d.mts files.

See rollup/plugins#1541 for reference

@eXon eXon enabled auto-merge (squash) March 31, 2024 17:17
@eXon eXon merged commit d9bc144 into main Mar 31, 2024
3 checks passed
@eXon eXon deleted the bugfix/esm-typescript-type branch March 31, 2024 17:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant