Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not update during render #467

Merged
merged 2 commits into from
Mar 31, 2024
Merged

fix: do not update during render #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6232c6b
fix: do not update during render
SantoJambit Mar 21, 2024
8dafd54
chore: prettier
SantoJambit Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react-cookie/src/useCookies.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ export default function useCookies<T extends string, U = { [K in T]?: any }>(
throw new Error('Missing <CookiesProvider>');
}

const [allCookies, setCookies] = useState(() => cookies.getAll());
const [allCookies, setCookies] = useState(() =>
cookies.getAll({ doNotUpdate: true }),
);

if (isInBrowser()) {
useLayoutEffect(() => {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-cookie/src/withCookies.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default function withCookies<T extends ReactCookieProps>(

render() {
const { forwardedRef, cookies, ...restProps } = this.props;
const allCookies = cookies.getAll();
const allCookies = cookies.getAll({ doNotUpdate: true });
return (
<WrappedComponent
{...(restProps as T)}
Expand Down