Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix : Fix ESM exports #441

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Hotfix : Fix ESM exports #441

merged 4 commits into from
Jan 5, 2024

Conversation

thib3113
Copy link
Contributor

@thib3113 thib3113 commented Jan 3, 2024

V7.0.0 breaks typescript because of the exports, Fix #440

So, I update them like :

  • all root properties are for CJS
  • exports are used only by ESM

I also added default for bundler that doesn't handle import or require .

( in general, I also use .cjs extension for cjs files, and .cts for cjs typing, but maybe not needed for an hotfix )

@rogulikAFC
Copy link

Thank you, it works fine :)

@pinarruiz
Copy link

Can verify this fixes #440

@mikehdt
Copy link

mikehdt commented Jan 4, 2024

Probably good advice to not release major changes which accidentally do break things on / close to NYE 😂

@thib3113
Copy link
Contributor Author

thib3113 commented Jan 5, 2024

ping @eXon (in case you don't get notified) . This issue is blocking typescript builds, needing to go back to old version .

Can you at least allow workflow so I can check if the tests are passing on your Ci ?

Copy link
Collaborator

@eXon eXon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Would it be possible to also do the same change for all packages, not only universal-cookie?

packages/universal-cookie/package.json Show resolved Hide resolved
packages/universal-cookie/package.json Outdated Show resolved Hide resolved
@thib3113
Copy link
Contributor Author

thib3113 commented Jan 5, 2024

@eXon can you re-allow the workflow please ? ( I will try to run tests, but scripts are not compatible with windows, and running them in wsl is extremely slow )

( I will rebase the commits if the tests works )


Because the git hooks doesn't work on windows, I need to do it on wsl, and so the commit is not signed

@eXon
Copy link
Collaborator

eXon commented Jan 5, 2024

@thib3113 Would it be possible to resign your commit using Windows by skipping the pre-commit hook? You can do something like this: git rebase --exec 'git commit --no-verify --amend --no-edit -n -S' -i main

@eXon eXon enabled auto-merge (squash) January 5, 2024 15:21
@eXon
Copy link
Collaborator

eXon commented Jan 5, 2024

@thib3113 Thank you for your contribution! I should be able to release 7.0.1 by tomorrow.

@eXon eXon merged commit 99dc0ff into bendotcodes:main Jan 5, 2024
1 check passed
@thib3113 thib3113 deleted the hotfix-typing branch January 5, 2024 15:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import errors in universal-cookie and react-cookie
5 participants