Fix Readme React hook example code typo (prop name) #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right, thank you for the fix! |
eXon
force-pushed
the
Fix-Readme-React-hook-example-code-typo
branch
from
463eee0
to
3de01a6
Compare
eXon
force-pushed
the
Fix-Readme-React-hook-example-code-typo
branch
from
3de01a6
to
724222f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While using this lib in react project, I copy&pasted the sample code from section
Simple Example with React hooksin ReadMe.md.I looked up the exported types and spotted a missing mismatching prop name. (
defaultSetCookiesis not a property ofCookiesProvider, did you meandefaultSetOptions?)Fixing it would help a lot of people avoid the type error when following the documentation.
Thank you for the project and taking time to review my pull request.