Fix cookie not being parsed on load. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have to stringify your object before saving, and you add that, to the `_cookies` cache, then you'll return that on `load` after setting it with `save`. While if the value is already set, the script correctly parses the cookie values and what you load is returned as an object. This oneliner takes care of that for you.
eXon
added a commit
that referenced
this pull request
Apr 19, 2015
Fix cookie not being parsed on load.
|
You are absolutely right. Nice catch 👍 |
|
Thanks. Can you publish the changes on npm too please? ;) |
|
Will be done in the upcoming days once I'm sure their is no issues with this |
|
From the top of my head. If you send in a stringified object, then when you Also, right now you don't expose any API for deleting a cookie. 2015-04-19 19:37 GMT+02:00 Benoit Tremblay [email protected]:
|
|
You can now update to 0.1.8 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have to stringify your object before saving, and you add that,
to the
_cookiescache, then you'll return that onloadafter settingit with
save.While if the value is already set, the script correctly parses the cookie
values and what you load is returned as an object.
This oneliner takes care of that for you.