Memory leak with v6

[denchiklut]

After updating to v6, I started having a memory leak issue.
After comparing Heap snapshots, I noticed lots of links in retained objects of changeListeners in Cookie

Downgrading react-cookie & universal-cookie-express to 5.0.0 solved the memory leak issue.

 npx envinfo --system --binaries --npmPackages universal-cookie-express,react-cookie,universal-cookie                                ✔ 
  System:
    OS: macOS 13.6
    CPU: (8) arm64 Apple M1 Pro
    Memory: 445.11 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.14.0 - ~/.nvm/versions/node/v18.14.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.14.0/bin/yarn
    npm: 9.3.1 - ~/.nvm/versions/node/v18.14.0/bin/npm
    pnpm: 8.3.1 - ~/.nvm/versions/node/v18.14.0/bin/pnpm
  npmPackages:
    react-cookie: ^6.1.1 => 6.1.1 
    universal-cookie-express: ^6.1.1 => 6.1.1 

[meros]

I've seen this as well.

[meros]

After some investigation I think this is the culprit: 7816526

The interval keeps an instance to this, that causes the whole cookie class to be retained.

[Reeywhaar]

Can confirm. After adding removeChangeListener we've fixed our app's memory leak

[meros]

My problem is that I am using express middleware, that adds a change listener. It's not possible for me to remove this as I don't have access to the listener function itself.

[Reeywhaar]

Then you should address it to the middleware author I guess? Is it available on github?

[meros]

It's in this repo as well:

cookies/packages/universal-cookie-express/src/index.ts

Line 7 in 7fa4cee

req.universalCookies.addChangeListener((change: CookieChangeOptions) => {

[dawecode]

Memory leak is happening on our app as well, downgrading has solved it for now.

[cbazureau]

Same here, already revert universal-cookie-express update on the end of september due to memory leak just after an upgrade to 6.1.1.

[eXon]

Will be fixed in next release

[eXon]

Released in v6.1.2