Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When calling Universal Cookie.remove the default set options do not work #396

Closed
derekbassett opened this issue Sep 20, 2023 · 2 comments
Closed

Comments

@derekbassett
Copy link
Contributor

derekbassett commented Sep 20, 2023

If I configure a universal Cookie to map to a specific domain or path in the constructor. I would expect that I can remove that cookie without passing in additional information other than the name.
I enabled with react-cookie given remove/set a very similar I would expect the default values I pass into the constructor would also be included in the remove call.

cookies = new Cookies(null, {path: `/meow`});
cookies.set('testMeOut','value');
cookies.remove('testMeOut'); // I would expect the cookie set above would be removed.
eXon added a commit that referenced this issue Dec 30, 2023
* Pass default set options to remove

* Fix unnecessary import & missing whitespace

---------

Co-authored-by: Derek Bassett <[email protected]>
@eXon
Copy link
Collaborator

eXon commented Dec 30, 2023

Will be fixed in next release

@eXon eXon closed this as completed Dec 30, 2023
@eXon
Copy link
Collaborator

eXon commented Dec 30, 2023

Released in v6.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants