Merge pull request #228 from rowan-m/samesite-none

Support explicit None value for sameSite attribute
bendotcodes · Jul 11, 2019 · 9ab2474 · 9ab2474
2 parents 508567a + 432d695
commit 9ab2474
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ##vNEXT
 
+- `universal-cookie`: Add support for explicit `None` value on `sameSite` attribute
 ##v4.0.1
 
 - Upgrade dependencies to last versions

diff --git a/packages/react-cookie/README.md b/packages/react-cookie/README.md
@@ -84,7 +84,7 @@ Set a cookie value
   - domain (string): domain for the cookie (sub.domain.com or .allsubdomains.com)
   - secure (boolean): Is only accessible through HTTPS?
   - httpOnly (boolean): Is only the server can access the cookie?
-  - sameSite (boolean|lax|strict): Strict or Lax enforcement
+  - sameSite (boolean|none|lax|strict): Strict or Lax enforcement
 
 ### `removeCookie(name, [options])`
 
@@ -98,7 +98,7 @@ Remove a cookie
   - domain (string): domain for the cookie (sub.domain.com or .allsubdomains.com)
   - secure (boolean): Is only accessible through HTTPS?
   - httpOnly (boolean): Is only the server can access the cookie?
-  - sameSite (boolean|lax|strict): Strict or Lax enforcement
+  - sameSite (boolean|none|lax|strict): Strict or Lax enforcement
 
 ## `withCookies(Component)`
 
@@ -147,7 +147,7 @@ Set a cookie value
   - domain (string): domain for the cookie (sub.domain.com or .allsubdomains.com)
   - secure (boolean): Is only accessible through HTTPS?
   - httpOnly (boolean): Is only the server can access the cookie?
-  - sameSite (boolean|lax|strict): Strict or Lax enforcement
+  - sameSite (boolean|none|lax|strict): Strict or Lax enforcement
 
 ### `remove(name, [options])`
 
@@ -161,7 +161,7 @@ Remove a cookie
   - domain (string): domain for the cookie (sub.domain.com or .allsubdomains.com)
   - secure (boolean): Is only accessible through HTTPS?
   - httpOnly (boolean): Is only the server can access the cookie?
-  - sameSite (boolean|lax|strict): Strict or Lax enforcement
+  - sameSite (boolean|none|lax|strict): Strict or Lax enforcement
 
 ## Simple Example with React hooks
 

diff --git a/packages/universal-cookie/README.md b/packages/universal-cookie/README.md
@@ -53,7 +53,7 @@ Set a cookie value
   - domain (string): domain for the cookie (sub.domain.com or .allsubdomains.com)
   - secure (boolean): Is only accessible through HTTPS?
   - httpOnly (boolean): Is only the server can access the cookie?
-  - sameSite (boolean|lax|strict): Strict or Lax enforcement
+  - sameSite (boolean|none|lax|strict): Strict or Lax enforcement
 
 ### `remove(name, [options])`
 Remove a cookie
@@ -65,7 +65,7 @@ Remove a cookie
   - domain (string): domain for the cookie (sub.domain.com or .allsubdomains.com)
   - secure (boolean): Is only accessible through HTTPS?
   - httpOnly (boolean): Is only the server can access the cookie?
-  - sameSite (boolean|lax|strict): Strict or Lax enforcement
+  - sameSite (boolean|none|lax|strict): Strict or Lax enforcement
 
 ### `addChangeListener(callback)`
 Add a listener to when a cookie is set or removed.

diff --git a/packages/universal-cookie/src/types.ts b/packages/universal-cookie/src/types.ts
@@ -11,7 +11,7 @@ export interface CookieSetOptions {
   domain?: string;
   secure?: boolean;
   httpOnly?: boolean;
-  sameSite?: boolean | 'lax' | 'strict';
+  sameSite?: boolean | 'none' | 'lax' | 'strict';
 }
 export interface CookieChangeOptions {
   name: string;