Use standard cookies with jsdom (fix #236 and #237)

bendotcodes · Dec 27, 2019 · 5939056 · morficus · May 1, 2020 · 5939056
1 parent 41943ba
commit 5939056
Show file tree

Hide file tree

Showing 5 changed files with 1,572 additions and 35 deletions.
diff --git a/packages/react-cookie-demo/package.json b/packages/react-cookie-demo/package.json
@@ -5,7 +5,8 @@
   "license": "MIT",
   "main": "server.js",
   "scripts": {
-    "build": "webpack"
+    "build": "webpack",
+    "test": "jest"
   },
   "dependencies": {
     "@babel/register": "^7.0.0",
@@ -22,7 +23,11 @@
     "@babel/preset-env": "^7.0.0",
     "@babel/preset-react": "^7.0.0",
     "@babel/preset-stage-2": "^7.0.0",
+    "@testing-library/react": "^9.4.0",
+    "babel-jest": "^24.9.0",
     "babel-loader": "^8.0.0",
+    "jest": "^24.9.0",
+    "react-test-renderer": "^16.12.0",
     "webpack": "^4.16.5",
     "webpack-cli": "^3.1.0"
   }

diff --git a/packages/react-cookie-demo/src/components/App.test.js b/packages/react-cookie-demo/src/components/App.test.js
@@ -0,0 +1,15 @@
+import React from 'react';
+import { cleanup, fireEvent, render } from '@testing-library/react';
+import App from './App';
+import { Cookies } from 'react-cookie';
+
+afterEach(cleanup);
+
+test('Changing the name change the cookie value', () => {
+  const cookies = new Cookies();
+  const utils = render(<App />);
+  const input = utils.getByPlaceholderText('Enter your name');
+  fireEvent.change(input, { target: { value: 'Ben Solo' } });
+  expect(input.value).toBe('Ben Solo');
+  expect(cookies.get('name')).toBe('Ben Solo');
+});
diff --git a/packages/react-cookie-demo/src/components/NameForm.js b/packages/react-cookie-demo/src/components/NameForm.js
@@ -12,6 +12,7 @@ export default function NameForm({ name, onChange }) {
       >
         <input
           type="text"
+          placeholder="Enter your name"
           defaultValue={name}
           onChange={e => onChange(e.target.value)}
         />

diff --git a/packages/universal-cookie/src/utils.ts b/packages/universal-cookie/src/utils.ts
@@ -2,29 +2,10 @@ import * as cookie from 'cookie';
 import { Cookie, CookieGetOptions, CookieParseOptions } from './types';
 
 export function hasDocumentCookie() {
-  // JSDOM does not support changing cookies, disable it for tests
-  if (isJsDom()) {
-    return false;
-  }
-
   // Can we get/set cookies on document.cookie?
   return typeof document === 'object' && typeof document.cookie === 'string';
 }
 
-function isJsDom(): boolean {
-  if (
-    typeof navigator !== 'object' ||
-    typeof navigator.userAgent !== 'string'
-  ) {
-    return false;
-  }
-
-  return (
-    navigator.userAgent.indexOf('Node.js') >= 0 ||
-    navigator.userAgent.indexOf('jsdom') >= 0
-  );
-}
-
 export function cleanCookies() {
   document.cookie.split(';').forEach(function(c) {
     document.cookie = c