Added directive js_collect_targets #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewianda
reviewed
Oct 9, 2024
ColinHeathman
changed the title
ewianda
reviewed
Oct 9, 2024
ewianda
reviewed
Oct 9, 2024
ColinHeathman
force-pushed
the
collect-pages
branch
4 times, most recently
from
c4ce0aa to
07ae5f5
Compare
style page root to mark each direct leaf as a page
ColinHeathman
force-pushed
the
collect-pages
branch
2 times, most recently
from
0a7bbf9 to
23c8701
Compare
into it's own rule.
ColinHeathman
force-pushed
the
collect-pages
branch
from
23c8701 to
42b3ea5
Compare
Reworked the nextjs specific directives to be a "js_collect_targets" directive while making use of the existing "js_collect_all" directive for similar behaviour
ColinHeathman
changed the title
ewianda
reviewed
Oct 11, 2024
| generatedRules = append(generatedRules, generatedAWARules...) | ||
| generatedImports = append(generatedImports, generatedAWAImports...) | ||
|
|
||
| generatedTSRules, generatedTSImports := lang.genCollectedTargetsRule( |
There was a problem hiding this comment.
I don't understand how referencing works, is calling this generatedTSRules, generatedTSImports make the imports to be overwritten
ewianda
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js_collect_pages which can be used in a NextJS style page root to mark each direct leaf as a page