Lazily initialize docker registry client #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Exit early if connection to docker daemon fails * Fix mutex bugs * Fix image buildinfo getting "stuck" and requiring killing of the process
Equanox
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows running bob without errors if:
bob build ls) does not require interaction with docker.If the bobfile requires docker for some operation, and docker is not present, then it exits early with a user error, without showing a stacktrace.
It also addresses a potential mutex bug (Unlock was not deferred and there was no unlock call in an if-return branch later on).
It should address issues reported by users not having Docker installed, e.g. #327