Skip to content

Commit

Permalink
dont check filehash on verifyShallow
Browse files Browse the repository at this point in the history
  • Loading branch information
Equanox committed Mar 29, 2023
1 parent a9abaf8 commit 6749119
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion bobtask/target/verify.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ func (t *T) verifyFilesystemShallow(v *VerifyResult) bool {
boblog.Log.V(2).Info(fmt.Sprintf("failed to verify [%s], different sizes [current: %d != expected: %d]", path, fileInfo.Size(), expectedFileInfo.Size))
}

// Not comparing hashes of targets for now due to the performance penalty.
//
// // checks the contents hash of the file with the ones from build info
// hashOfFile, err := filehash.HashOfFile(path)
// if err != nil {
Expand All @@ -159,7 +161,7 @@ var IgnoredTargets = []string{"node_modules/.cache"}
// when creating/extracting artifact or creating the buildinfo
func ShouldIgnore(path string) bool {
for _, v := range IgnoredTargets {
if strings.HasPrefix(path, v) {
if strings.Contains(path, v) {
return true
}
}
Expand Down

0 comments on commit 6749119

Please sign in to comment.