use docker lock less exaustive

benchkram · Jan 5, 2023 · 49f9683 · 49f9683
1 parent 1de11ba
commit 49f9683
Showing 1 changed file with 0 additions and 10 deletions.
diff --git a/pkg/dockermobyutil/registry.go b/pkg/dockermobyutil/registry.go
@@ -72,13 +72,10 @@ func (r *R) ImageExists(image string) (bool, error) {
 }
 
 func (r *R) ImageHash(image string) (string, error) {
-	r.mutex.Lock()
 	summaries, err := r.client.ImageList(context.Background(), types.ImageListOptions{All: false})
 	if err != nil {
-		r.mutex.Unlock()
 		return "", err
 	}
-	r.mutex.Unlock()
 
 	var selected types.ImageSummary
 	for _, s := range summaries {
@@ -98,13 +95,10 @@ func (r *R) ImageHash(image string) (string, error) {
 }
 
 func (r *R) imageSaveToPath(image string, savedir string) (pathToArchive string, _ error) {
-	r.mutex.Lock()
 	reader, err := r.client.ImageSave(context.Background(), []string{image})
 	if err != nil {
-		r.mutex.Unlock()
 		return "", err
 	}
-	r.mutex.Unlock()
 	defer reader.Close()
 
 	body, err := ioutil.ReadAll(reader)
@@ -135,8 +129,6 @@ func (r *R) ImageSave(image string) (pathToArchive string, _ error) {
 
 // ImageRemove from registry
 func (r *R) ImageRemove(imageID string) error {
-	r.mutex.Lock()
-	defer r.mutex.Unlock()
 	options := types.ImageRemoveOptions{
 		Force:         true,
 		PruneChildren: true,
@@ -169,8 +161,6 @@ func (r *R) ImageLoad(imgpath string) error {
 
 // ImageLoad from tar archive
 func (r *R) ImageTag(src string, target string) error {
-	r.mutex.Lock()
-	defer r.mutex.Unlock()
 	return r.client.ImageTag(context.Background(), src, target)
 }