Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LadybugTools #77

Merged
merged 8 commits into from
Oct 5, 2019
Merged

add LadybugTools #77

merged 8 commits into from
Oct 5, 2019

Conversation

tasawernawaz
Copy link
Contributor

Fixes #75

Copy link
Contributor

@Ishaan28malik Ishaan28malik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update it a per the alphabetical order.

@benbarth
Copy link
Owner

benbarth commented Oct 4, 2019

Hi @tasawernawaz, thank you for taking the time to create a PR! This PR is failing validation for the same reason as #78. (The list is no longer in alphabetical order.) If you correct the order I'd be happy to merge this PR.

@tasawernawaz
Copy link
Contributor Author

@benbarth fix failing tests

Copy link
Owner

@benbarth benbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! You removed the 2019 updates.

@benbarth
Copy link
Owner

benbarth commented Oct 5, 2019

I think LadyBug should be before LBRY. I'll fix the build/validation script.

@tasawernawaz
Copy link
Contributor Author

Whoops! You removed the 2019 updates.

Sorry, that was a typo. I have moved Ladybug before LBRY.

@tasawernawaz tasawernawaz mentioned this pull request Oct 5, 2019
@benbarth benbarth merged commit 13e7d86 into benbarth:master Oct 5, 2019
@tasawernawaz tasawernawaz deleted the patch-1 branch October 5, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ladybug Tools
3 participants