Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #2: Added awesome_bot and build passing badge in README.md #3

Merged
merged 2 commits into from
Oct 2, 2018
Merged

issue #2: Added awesome_bot and build passing badge in README.md #3

merged 2 commits into from
Oct 2, 2018

Conversation

nityanandagohain
Copy link
Contributor

fixes #2

@benbarth
Copy link
Owner

benbarth commented Oct 1, 2018

Hi Nityananda,
These changes are great; however, the badge should be for Travis Ci not Buildkite. An example can be found at https://github.com/benbarth/essential-apps. After changing the badge, please verify that the build runs successfully.

@nityanandagohain
Copy link
Contributor Author

I have done the changes, is it okay?

@nityanandagohain
Copy link
Contributor Author

@benbarth please help me with the issues.

@benbarth
Copy link
Owner

benbarth commented Oct 1, 2018

Sure, I can help. I'll be available in a few hours. I'll add more detail as to why the build is failing.

@benbarth
Copy link
Owner

benbarth commented Oct 2, 2018

Clicking the build failed details takes you to: https://travis-ci.org/benbarth/hacktoberfest-swag/builds/435608182

There you can see four issues :-(

> Links 
  1. [L07] 301 https://travis-ci.org/benbarth/hacktoberfest-swag.svg?branch=master  → https://api.travis-ci.org/benbarth/hacktoberfest-swag.svg?branch=master 
  2. [L24] 302 https://blog.hasura.io/announcing-hacktoberfest-2018-with-hasura-621045dc9560  → https://medium.com/m/global-identity?redirectUrl=https%3A%2F%2Fblog.hasura.io%2Fannouncing-hacktoberfest-2018-with-hasura-621045dc9560 
  3. [L25] 301 https://aka.ms/hacktoberfest  → https://open.microsoft.com/2018/09/30/join-hacktoberfest-2018-celebration-microsoft/?WT.mc_id=hacktoberfest-none-beverst 
> Dupes 
  1. [L14] https://hacktoberfest.digitalocean.com/

For the links: The errors are because of a redirects. These can be solved by adding --allow-redirect to the awesome_bot command.
For the dupes: It should be added to a whitelist by adding --white-list https://hacktoberfest.digitalocean.com/.

The awesome_bot documentation can be found here: https://github.com/dkhamsing/awesome_bot

@nityanandagohain
Copy link
Contributor Author

Thanks, @benbarth I have made the required changes and now the build is passing.

@benbarth
Copy link
Owner

benbarth commented Oct 2, 2018

Looks good! Merging...

@benbarth benbarth merged commit 92e2474 into benbarth:master Oct 2, 2018
@nityanandagohain nityanandagohain deleted the issue#2 branch October 2, 2018 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add awesome_bot to verify README.md links
2 participants