Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon pack #28

Merged
merged 7 commits into from
Oct 22, 2018
Merged

Add icon pack #28

merged 7 commits into from
Oct 22, 2018

Conversation

justinh5
Copy link
Contributor

For #25. They're a bit minamalistic haha.

@benbarth
Copy link
Owner

@justinh5 I just added the icons to the README on your branch. It looks like the sticker icon has white pixels around the black pixels. The icons will be displayed on a black background as well. https://benbarth.github.io/hacktoberfest-swag/ Can the greyscale icons be closer to half white and half black?

@justinh5
Copy link
Contributor Author

@benbarth Yes that's a problem. My concern with using midtones is that they'll look washed out if they are to work with both black and white backgrounds. Also there seems to be a problem with the tshirt and socks icons not rendering. I'll try to fix it.

@justinh5
Copy link
Contributor Author

Okay the greyscale icons should work for both dark and light backgrounds now. What do you think? @benbarth

@benbarth
Copy link
Owner

I think they look great! Thanks @justinh5!
If you think the icons are ready, I'm ready to accept the PR. Can you fix the merge conflict?

@justinh5
Copy link
Contributor Author

Sweet! Fixed the conflict. They're still not perfect, but it's a start.

@benbarth benbarth merged commit 63c70e7 into benbarth:master Oct 22, 2018
@benbarth
Copy link
Owner

Merged! 🎉
Thanks again @justinh5! 🤜🤛
If you want to make any changes to the icons just send a PR.

@benbarth benbarth mentioned this pull request Oct 22, 2018
@StrikerRUS
Copy link
Contributor

Hi guys!

Seems that this PR accidentally removed info about OpenBazaar (#29) 😕

@benbarth
Copy link
Owner

benbarth commented Nov 2, 2018

Good catch @StrikerRUS! Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants