Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Mattermost for 2021 #194

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Verify Mattermost for 2021 #194

merged 2 commits into from
Sep 30, 2021

Conversation

donno2048
Copy link
Contributor

No description provided.

Copy link
Collaborator

@SoftCreatR SoftCreatR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unnecessary line breaks.

@SoftCreatR SoftCreatR merged commit 14f4346 into benbarth:master Sep 30, 2021
@donno2048
Copy link
Contributor Author

I just copied the example file from the CONTRIBUTING.md, the line breaks came from there

@donno2048 donno2048 deleted the patch-1 branch September 30, 2021 17:33
@SoftCreatR
Copy link
Collaborator

Like you said: That's just an example :) The easiest would have been to just move the file from the 2020 directory and change it's contents accordingly.

@ulgens
Copy link

ulgens commented Oct 1, 2021

I can't see why you are moving files away from 2020 instead of copying them. Why not just keep 2020 as is?

@SoftCreatR
Copy link
Collaborator

To prevent duplicates. No one likes duplicates.

😸

@ulgens
Copy link

ulgens commented Oct 1, 2021

Why would there be duplicates between different folders?

@SoftCreatR
Copy link
Collaborator

SoftCreatR commented Oct 1, 2021

Why is this even a problem? We just decided to keep the repo as clean as possible. Furthermore, the whole, automated CI process is not designed for duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants