Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DigitalOcean as sponsor #140

Merged
merged 5 commits into from
Oct 2, 2020
Merged

Add DigitalOcean as sponsor #140

merged 5 commits into from
Oct 2, 2020

Conversation

benbarth
Copy link
Owner

@benbarth benbarth commented Oct 2, 2020

No description provided.

@benbarth benbarth merged commit d075b67 into master Oct 2, 2020
@benbarth benbarth deleted the digitalocean-as-sponsor branch October 2, 2020 03:23
@SoftCreatR
Copy link
Collaborator

Shouldn't it be digitalocean.yml instead?

Furthermore, your change may lead to unexpected behavior. Participants are sorted ascending by their name (filename). Since DigitalOcean is the initiator, they should always be on top of the list. This woulnd't be the case, if a sponsor starts with a, b or c ;)

@benbarth
Copy link
Owner Author

benbarth commented Oct 2, 2020

Yeah, I was thinking hacktoberfest.yml could always be first. Or maybe there's a better way of annotating it.

Ideally, the script will become stable and never change. The description and detail for DigitalOcean will change.

@SoftCreatR
Copy link
Collaborator

Just pushed an update that ensures, that the given participant within the hacktoberfest.yml will always be listed at the top of the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants