Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Overhaul #125

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Repo Overhaul #125

merged 2 commits into from
Oct 1, 2020

Conversation

SoftCreatR
Copy link
Collaborator

  • Move participants into separate files and folders
  • Remove script validate-alphabetical.py
  • Add script update_readme.py
  • Add workflow
  • Add JSON Schema for participant file validation
  • Update existing workflow
  • Update README
  • Add generic Hacktoberfest logo
  • Rename tshirt to shirt
  • Add CODE_OF_CONDUCT.md
  • Rename contributing.md to CONTRIBUTING.md

SoftCreatR and others added 2 commits September 30, 2020 21:42
- Moved participants into separate files and folders
- Removed script validate-alphabetical.py
- Added script update_readme.py
- Added workflow
- Added JSON Schema for participant file validation
- Updated existing workflow
- Updated README
- Added generic Hacktoberfest logo
- Fixed contributing.md
- Renamed tshirt to shirt
- Added CODE_OF_CONDUCT.md
- Renamed contributing.md to CONTRIBUTING.md
@SoftCreatR
Copy link
Collaborator Author

SoftCreatR commented Sep 30, 2020

Btw: After merging, the CONTRIBUTING.md needs your attention @benbarth

And please, restart the workflow here before merging.

@benbarth benbarth merged commit 4299adb into benbarth:master Oct 1, 2020
@benbarth
Copy link
Owner

benbarth commented Oct 1, 2020

🏆 @SoftCreatR wins "Best PR."

@SoftCreatR
Copy link
Collaborator Author

@benbarth You may try out the new workflow by adding a participant yml file ;) Only if that works on the 1st try, i made a good job :octocat:

@benbarth
Copy link
Owner

benbarth commented Oct 1, 2020

I received an email:

The page build failed for the master branch with the following error:

Page build failed. For more information, see https://docs.github.com/github/working-with-github-pages/troubleshooting-jekyll-build-errors-for-github-pages-sites#troubleshooting-build-errors.

For information on troubleshooting Jekyll see:

https://docs.github.com/articles/troubleshooting-jekyll-builds

@SoftCreatR
Copy link
Collaborator Author

I've seen this already. Unfortunately, there's no reason given for the failure.

You may try triggering the build again.

@benbarth
Copy link
Owner

benbarth commented Oct 1, 2020

I ran the workflow again and everything succeeded... unfortunately the Jekyll website isn't updating.

@SoftCreatR
Copy link
Collaborator Author

I found a hand full of issues within the README file. I'll try to fix them. Maybe, that does the trick.

@benbarth
Copy link
Owner

benbarth commented Oct 1, 2020

🤞

@SoftCreatR
Copy link
Collaborator Author

I ran the workflow again and everything succeeded... unfortunately the Jekyll website isn't updating.

Hitting the "Re-run jobs" button isn't the correct solution ;) This doesn't trigger the gh-pages workflow. However, i've created another PR with some modifications to the README file. Let's see, if that works.

@SoftCreatR SoftCreatR deleted the auto-readme branch October 1, 2020 00:43
@SoftCreatR
Copy link
Collaborator Author

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants