fix: #135 #140
Merged
fix: #135 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #140 +/- ##
===========================================
- Coverage 93.77% 93.73% -0.04%
===========================================
Files 20 20
Lines 546 543 -3
Branches 123 121 -2
===========================================
- Hits 512 509 -3
Misses 34 34
Continue to review full report at Codecov.
|
AnatoleLucet
force-pushed
the
fix/forward-slashes-on-windows
branch
from
07c0116
to
8a2a1c0
Compare
This was referenced May 22, 2020
benawad
approved these changes
May 22, 2020
|
Is there any word on having this released as a patch version? |
|
@ChrisBrownie55 I'll release it if you want. |
|
@AnatoleLucet I'd really appreciate it! Can't currently use this project on Windows without out it lol |
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this issue: nodejs/node#31710, Node doesn't support backslash in an import. So I've just dropped the backslash when writing imports, but paths are still logged with backslash on windows (as they should).