Skip to content

Remove all print statements #93 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2024
Merged

Remove all print statements #93 #95

merged 2 commits into from
Jan 9, 2024

Conversation

shreyasSarve
Copy link
Contributor

  • added logging functionality from python
  • logs will be shown with date-time

@shreyasSarve
Remove all print statements benavlabs#93
ac96ea1 
- added logging functionality from python
- logs will be shown with date-time
@igorbenav igorbenav self-requested a review January 7, 2024 17:43
igorbenav
igorbenav requested changes Jan 7, 2024
View reviewed changes
Copy link
Collaborator

@igorbenav igorbenav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the level to INFO? Plus, format should be "%(asctime)s - %(name)s - %(levelname)s - %(message)s"

@igorbenav igorbenav self-assigned this Jan 7, 2024
@shreyasSarve
benavlabs#93 Remove All Print message
c76729c 
change logging level to info & message formate as requested
@shreyasSarve
Copy link
Contributor Author

requested changes been added

@shreyasSarve shreyasSarve requested a review from igorbenav January 8, 2024 09:15
@igorbenav igorbenav merged commit c167cc8 into benavlabs:main Jan 9, 2024
@igorbenav igorbenav mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbenav igorbenav igorbenav approved these changes

Assignees

@igorbenav igorbenav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyasSarve @igorbenav