Skip to content

Fixes #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Fixes #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
049a0e7
exception fixx
igorbenav Jul 4, 2024
da11ad4
exists check fixed to bool instead of is None
igorbenav Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/app/api/v1/rate_limits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ async def patch_rate_limit(
raise NotFoundException("Rate Limit not found")

db_rate_limit_path = await crud_rate_limits.exists(db=db, tier_id=db_tier["id"], path=values.path)
if db_rate_limit_path is not None:
if db_rate_limit_path:
raise DuplicateValueException("There is already a rate limit for this path")

await crud_rate_limits.exists(db=db)
if db_rate_limit_path is not None:
if db_rate_limit_path:
raise DuplicateValueException("There is already a rate limit with this name")

await crud_rate_limits.update(db=db, object=values, id=db_rate_limit["id"])
Expand All @@ -113,7 +113,7 @@ async def erase_rate_limit(

db_rate_limit = await crud_rate_limits.get(db=db, schema_to_select=RateLimitRead, tier_id=db_tier["id"], id=id)
if db_rate_limit is None:
raise RateLimitException("Rate Limit not found")
raise NotFoundException("Rate Limit not found")

await crud_rate_limits.delete(db=db, id=db_rate_limit["id"])
return {"message": "Rate Limit deleted"}