Fixes default expire time in creating access token #143
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the default expire timedelta used in the function to create an access token. The default timedelta in create_access_token is updated from '15' to the config setting of ACCESS_TOKEN_EXPIRE_MINUTES. This matches the behavior of the create_refresh_token function right below it, which uses the config setting of REFRESH_TOKEN_EXPIRE_DAYS for its default expire timedelta. (ACCESS_TOKEN_EXPIRE_MINUTES was also already imported into the file for this likely purpose while not being used.)
|
Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the default expire timedelta used in the function to create an access token.
The default timedelta in create_access_token is updated from '15' to the config setting of ACCESS_TOKEN_EXPIRE_MINUTES.
This matches the behavior of the create_refresh_token function right below it, which uses the config setting of REFRESH_TOKEN_EXPIRE_DAYS for its default expire timedelta. (ACCESS_TOKEN_EXPIRE_MINUTES was also already imported into the file for this likely purpose while not being used.)