Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One request mapping rebased #141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ryman
Copy link
Contributor

@Ryman Ryman commented Jul 23, 2019

Hey :)

This is a rebase of #111 without the stuff related to inner_hits which seemed to be stalling the PR.

I've also taken minor steps to avoid having a breaking change by removing the old mapping method.

Instead I've opted to deprecate that method and just implement it in terms of the new method (mappings) so that people can update at their leisure.

@benashford
Copy link
Owner

Thanks for this. I'm running out of time to review this today, but I'll come back to it shortly 👍

@Ryman
Copy link
Contributor Author

Ryman commented Aug 5, 2019

@benashford friendly ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants