Skip to content

Webpack HMR/websocket fix #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ben merged 3 commits into from
Jun 17, 2022
Merged

Webpack HMR/websocket fix #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d84799
Fix the constant websocket errors and enable HMR
ben Jun 17, 2022
60e3660
Enable webpack overlay for errors
ben Jun 17, 2022
bc8d28a
Update CHANGELOG.md
ben Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## In progress

- Code reorganization and format normalization
- Update to the right version of the Foundry types
- Fix the dev server for fewer errors, and so that HMR works

## 1.15.14

- Propagate region setting from location to scene
Expand Down
8 changes: 7 additions & 1 deletion webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,16 @@ module.exports = (env) => {
},
devServer: {
hot: true,
client: {
overlay: {
errors: true,
warnings: true,
},
},
proxy: [
{
context: (pathname) => {
return !pathname.match('^/sockjs')
return !pathname.match('^/ws')
},
target: 'http://localhost:30000',
ws: true,
Expand Down