Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dtx format support #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mugabe
Copy link

@mugabe mugabe commented Apr 14, 2018

Depends on bemusic/bms-js#28

Not sure about design.

Initialy I have an idea to pass file extension directly to format option, but it have possible issue with undefined matcher in bms module if the file with non bms/dtx extension passed.

So now here some smelling code to keep default behaviour.

@codecov-io
Copy link

codecov-io commented Apr 14, 2018

Codecov Report

Merging #1 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   97.37%   97.66%   +0.28%     
==========================================
  Files           8        8              
  Lines         267      300      +33     
==========================================
+ Hits          260      293      +33     
  Misses          7        7
Impacted Files Coverage Δ
src/loader/BMSNotechartLoader.js 100% <100%> (ø) ⬆️
src/index.js 94.59% <100%> (+0.47%) ⬆️
src/loader/index.js 94.73% <100%> (+0.98%) ⬆️
test/notechart-test.js 100% <100%> (ø) ⬆️
test/loader-test.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5866d...5cc7ac2. Read the comment docs.

@mugabe
Copy link
Author

mugabe commented Apr 18, 2018

  • Column generation added
    Columns are not ordered now, but as I see it does not make a sence for bemuse. Right?
    Column mapping options translated from playerOptions to bms-js.

  • noShifting option for skip chart transformation added

  • Updated ESLint dependencies
    Override ecmaVersion as async used

  • DTX support covered by tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants