Skip to content

Fixing JS Codestyle #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Fixing JS Codestyle #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 16 additions & 24 deletions build/media_source/com_workflow/js/admin-items-workflow-buttons.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,42 +45,36 @@ Joomla.toggleAllNextElements = (element, className) => {
const itemList = [].slice.call(document.querySelectorAll('table.itemList'))[0];

let itemListRows = [];
let transition_ids = [];
let transitionIds = [];

if (itemList) {
itemListRows = [].slice.call(itemList.querySelectorAll('tbody tr'));
}

function enableTransitions() {
if (transition_ids.length)
{
let availableTrans = transition_ids.shift();
if (transitionIds.length) {
let availableTrans = transitionIds.shift();

while(transition_ids.length)
{
const compareTrans = transition_ids.shift();
while (transitionIds.length) {
const compareTrans = transitionIds.shift();

availableTrans = availableTrans.filter((id) => {return compareTrans.indexOf(id) !== -1});
availableTrans = availableTrans.filter((id) => compareTrans.indexOf(id) !== -1);
}

if (availableTrans.length)
{
if (headline)
{
if (availableTrans.length) {
if (headline) {
headline.classList.remove('d-none');
}
if (separator)
{
if (separator) {
separator.classList.remove('d-none');
}
}

availableTrans.forEach((trans) => {
const elem = dropDownBtn.querySelector('.transition-' + trans);
const elem = dropDownBtn.querySelector(`.transition-${trans}`);

if (elem)
{
elem.parentNode.classList.remove('d-none')
if (elem) {
elem.parentNode.classList.remove('d-none');
}
});
}
Expand All @@ -89,7 +83,7 @@ Joomla.toggleAllNextElements = (element, className) => {
// check for common attributes for which the conditions for a transition are possible or not
// and save this information in a boolean variable.
function collectTransitions(row) {
transition_ids.push(row.getAttribute('data-transitions').split(','));
transitionIds.push(row.getAttribute('data-transitions').split(','));
}

// listen to click event to get selected rows
Expand All @@ -98,15 +92,13 @@ Joomla.toggleAllNextElements = (element, className) => {
transitions.forEach((trans) => {
trans.parentNode.classList.add('d-none');
});
if (headline)
{
if (headline) {
headline.classList.add('d-none');
}
if (separator)
{
if (separator) {
separator.classList.add('d-none');
}
transition_ids = [];
transitionIds = [];
itemListRows.forEach((el) => {
const checkedBox = el.querySelectorAll('input[type=checkbox]')[0];
if (checkedBox.checked) {
Expand Down