[CMS PR 43147] Use the right minimum stability#133
Merged
bembelimen merged 3 commits intobembelimen:tuf/update-fixesfrom Mar 27, 2024
Merged
Conversation
Owner
|
Thx for the improvements |
bembelimen
added a commit
that referenced
this pull request
Apr 1, 2024
* Update ConstraintChecker.php * Update UpdateModel.php * [CMS PR 43147] Use the right minimum stability (#133) * Deprecate language string * Validate customurl for URL type * Remove filter as we only want valid URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue joomla#43147 (comment) .
Summary of Changes
The minimum stability is passed as an option to the adapter and so can be used.
The existing parameter can be passed to the ConstraintChecker and the stability check.
This should fix the comment in the CMS PR mentioned above.
But I haven't tested it with your PR, I only have tested the same change when preparing my PR, which would have taken a bit longer.