[CMS PR 31804] Integrate with changes from CMS PR 31943 for dry run and verbose mode#127
Merged
bembelimen merged 3 commits intobembelimen:4.0/29794from Jan 27, 2021
Conversation
Author
|
It seems his came too late for the merge of your PR into J4, as your PR was merged before your merged this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#31804 (comment) .
Summary of Changes
Adapt your CMS PR joomla#31804 to some ugly code in the 4.0-dev branch ;-)
It could have been done in other ways for the "fixFilenameCasing", e.g. passing the result array by reference from the calling function "deleteUnexistingFiles" , and/or leaving the verbose output to the calling function, but the way I've done it here will allow us to change the "fixFilenameCasing" function to public so it can be called independently from the "deleteUnexistingFiles" function.
The last commit also includes the same changes as I propose with my new PR to the staging branch of the CMS.
Feel free to change whatever you want or to reject it completely and say the CMS PR is good as it is.
Testing Instructions
See if your PR still works and check with CLI if dry run and verbose mode work.