Merge pull request #140 from bem/issue-138

Add ignoring of duplicate 'css' classes
bem · Mar 16, 2016 · d322204 · d322204
2 parents fa61856 + 88dc255
commit d322204
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -81,7 +81,7 @@ For example, the following two code samples will be considered to be equivalent:
 ```
 
 ```html
-<span class=" cd  ab bc">Text</span>
+<span class=" cd  ab bc bc">Text</span>
 ```
 
 **CAUTION!**<br>

diff --git a/README.ru.md b/README.ru.md
@@ -81,7 +81,7 @@
 ```
 
 ```html
-<span class=" cd  ab bc">Text</span>
+<span class=" cd  ab bc bc">Text</span>
 ```
 
 **ВНИМАНИЕ!**<br>

diff --git a/lib/utils/utils.js b/lib/utils/utils.js
@@ -51,7 +51,11 @@ function sortCssClasses(attrs) {
     function _sortCssClassesValues(cssClasses) {
         var classList = (cssClasses || '').split(' ');
 
-        return _.filter(classList).sort().join(' ');
+        return _(classList)
+            .filter()
+            .uniq()
+            .sort()
+            .join(' ');
     }
 
     var classIndexes = _getIndexesInArray(attrs, 'class');

diff --git a/test/differ/fixtures/second/sort-classes.html b/test/differ/fixtures/second/sort-classes.html
@@ -1 +1 @@
-<input class=" cd  ab bc">
+<input class=" cd  ab bc bc">
diff --git a/test/unit/utils.js b/test/unit/utils.js
@@ -29,11 +29,13 @@ describe('\'utils\'', function () {
                 { name: 'class', value: ' b c a' },
                 { name: 'blah', value: 'b c a' },
                 { name: 'class', value: '' },
+                { name: 'class', value: 'a a a' }
             ],
             output = [
                 { name: 'class', value: 'a b c' },
                 { name: 'blah', value: 'b c a' },
-                { name: 'class', value: '' }
+                { name: 'class', value: '' },
+                { name: 'class', value: 'a' }
             ];
 
         utils.sortCssClasses(input).must.be.eql(output);