Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processBemJson() should return standart BEMJSON #96

Merged
merged 1 commit into from
Feb 16, 2015
Merged

processBemJson() should return standart BEMJSON #96

merged 1 commit into from
Feb 16, 2015

Conversation

mishanga
Copy link
Member

@mishanga mishanga commented Oct 1, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 9371025 on bemjson into af431af on master.

isqua
isqua reviewed Oct 8, 2014
View reviewed changes
test/test.processBemJson.js
content: {
block: 'button',
elem: 'inner',
mods: { valid: true }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be elemMods instead of mods? (As in BEMHTML)

@isqua
Copy link

isqua commented Nov 6, 2014

So what?

@mishanga
Copy link
Member Author

@isquariel наконец-то руки дошли :) Можешь проверить у себя?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.73% when pulling 1bdda6d on bemjson into 6cad88c on master.

qfox
qfox reviewed Feb 11, 2015
View reviewed changes
test/test.processBemJson.js
var BH = require('../lib/bh');
require('chai').should();

// Standart: http://ru.bem.info/technology/bemjson/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standarD

@mishanga
Copy link
Member Author

@an9eldust глянь, пожалуйста

@qfox
Copy link
Member

qfox commented Feb 14, 2015

@mishanga Маловато спеков, имхо. Надо пробовать запускать и с bh.match, это же основной кейс использования. Эта штука будет очень полезна для упрощенного аналога bemtree как слоя строящего дерево со своим набором матчеров.

@mishanga
Copy link
Member Author

@zxqfox про спеки не понял.

qfox
qfox reviewed Feb 16, 2015
View reviewed changes
test/test.processBemJson.js
}).should.deep.equal({
block: 'button',
mods: {}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может быть здесь пару тестов с match сделать и с прокидыванием данных внутрь?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем? Это ж юнит-тесты.
match сам по себе не модифицирует контекст, а в шаблонах можно воровать-убивать.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Разве match не запускается на processBemJson? Но вообще, наверное, не стоит, ведь мы их отдельно оттестировали.

@an9eldust
Copy link

@mishanga, я не увидел проблем, но надо сказать, что в этом коде я ориентируюсь не очень. Зато могу сообщить, что собрал наш проект с bh из этой ветки, и там все отлично.

@mishanga
Copy link
Member Author

@an9eldust ну это главное, что собралось и работает :) Я старался не ломать ничего.
Я тогда волью и выпущу тестовую версию, можно будет повнимательнее потестировать.

@qfox
Copy link
Member

qfox commented Feb 16, 2015

@mishanga 👍

mishanga added a commit that referenced this pull request Feb 16, 2015
@mishanga
Merge pull request #96 from bem/bemjson
c2719a9 
`processBemJson()` should return standart BEMJSON
@mishanga mishanga merged commit c2719a9 into master Feb 16, 2015
@mishanga mishanga deleted the bemjson branch February 16, 2015 15:38
qfox pushed a commit to bem/bh-php that referenced this pull request Apr 23, 2015
v4.0.0 fixes
a7ee911 
- Added global matcher support: `beforeEach` and `afterEach` (bem/bh#121).
- Added `ctx.process` method (bem/bh#135).
- Add `i-bem` class to element with `js` (bem/bh#122).
- No-base modifier classes supported (bem/bh#132).
- `processBemJson` now return standart BEMJSON (bem/bh#96).

Changelog bem/bh@ee446ea
qfox pushed a commit to bem/bh-php that referenced this pull request Apr 23, 2015
v4.0.0 fixes
0e2ceca 
- Added global matcher support: `beforeEach` and `afterEach` (bem/bh#121).
- Added `ctx.process` method (bem/bh#135).
- Add `i-bem` class to element with `js` (bem/bh#122).
- No-base modifier classes supported (bem/bh#132).
- `processBemJson` now return standart BEMJSON (bem/bh#96).

Changelog bem/bh@ee446ea
qfox pushed a commit to bem/bh-php that referenced this pull request Apr 23, 2015
v4.0.0 fixes
f714f5f 
- Added global matcher support: `beforeEach` and `afterEach` (bem/bh#121).
- Added `ctx.process` method (bem/bh#135).
- Add `i-bem` class to element with `js` (bem/bh#122).
- No-base modifier classes supported (bem/bh#132).
- `processBemJson` now return standart BEMJSON (bem/bh#96).

Changelog bem/bh@ee446ea
qfox pushed a commit to bem/bh-php that referenced this pull request Apr 23, 2015
v4.0.0 fixes
a1fa83a 
- Added global matcher support: `beforeEach` and `afterEach` (bem/bh#121).
- Added `ctx.process` method (bem/bh#135).
- Add `i-bem` class to element with `js` (bem/bh#122).
- No-base modifier classes supported (bem/bh#132).
- `processBemJson` now return standart BEMJSON (bem/bh#96).

Changelog bem/bh@ee446ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mishanga @coveralls @isqua @qfox @an9eldust