Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Assignment Multiplication #107

Closed
drocheam opened this issue Nov 6, 2021 · 1 comment
Closed

Incorrect Assignment Multiplication #107

drocheam opened this issue Nov 6, 2021 · 1 comment
Labels

Comments

@drocheam
Copy link

drocheam commented Nov 6, 2021

There's an error in the OprtAssignMul function (mpOprtBinAssign.cpp)

The line 191
*pVar = cmplx_type(a*c-b*d, a*d-b*c);

should be
*pVar = cmplx_type(a*c-b*d, a*d+b*c);

Check https://www.math-only-math.com/multiplication-of-two-complex-numbers.html for reference.

@beltoforion beltoforion added the bug label Nov 6, 2021
beltoforion pushed a commit that referenced this issue Nov 6, 2021
@beltoforion
Copy link
Owner

should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants