Add validator for Belgif openapi-employment-identifier EmployerId

[jpraet]

No description provided.

[jflabatBCSS]

I'm not familiar with employerId, I can't be sure your checksum verification are correct.

[jpraet]

I'm not familiar with employerId, I can't be sure your checksum verification are correct.

I based it on https://www.ict-reuse.be/nl/service/smalsutils-validation.
But indeed, it would be good if someone more familiar with this could also review it.

For example, in that library I also found "NssoCuratorRegistrationNumber" which does a different checksum calculation (it adds 5000000 before calculating the checksum). But I don't know if NssoCuratorRegistrationNumber is considered an EmployerId?

@pvdbosch could you ask a review from someone from Smals/RSZ?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jpraet]

According to smalsutils-validation there is overlap between NssoNumber range and PlaNumber range,
so I chose to also allow NSSO checksum when isInPlaRange() is true.

[pvdbosch]

For example, in that library I also found "NssoCuratorRegistrationNumber" which does a different checksum calculation (it adds 5000000 before calculating the checksum). But I don't know if NssoCuratorRegistrationNumber is considered an EmployerId?

I don't think it is. From FedVoc employerId definition: "Definitive or provisional NSSO number, assigned to each registered employer or local or provincial administration."

So this would correspond to NssoNumber+ProvisionalNssoNumber+PplNumber in smalsutils-validation.

@pvdbosch could you ask a review from someone from Smals/RSZ?

I can ask for an analyst to provide answers to business questions, but not for a code review because the analysts are no developers and we're not using this module. Aside from the question about NssoCuratorRegistrationNumber, I can ask to plan adding an equivalent EmployerId validation to smalsutils-validation. Are there any other questions you'd like to be answered?

[jpraet]

I can ask for an analyst to provide answers to business questions, but not for a code review because the analysts are no developers and we're not using this module. Aside from the question about NssoCuratorRegistrationNumber, I can ask to plan adding an equivalent EmployerId validation to smalsutils-validation. Are there any other questions you'd like to be answered?

Maybe a review from a developer that works on smalsutils-validation? I am mainly looking for some assurance that the checksum verification logic has been implemented correctly.